Hello @chiragkyal! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@chiragkyal: This pull request references OAPE-148 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

/test verify-feature-promotion

/retest

error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {vsphere amd64 ha }
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {metal amd64 ha ipv4}
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {metal amd64 ha ipv6}
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {metal amd64 ha dual}
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {aws amd64 ha }
error: only 0 tests found, need at least 5 for "CPMSMachineNamePrefix" on {azure amd64 ha }

It's not able to fetch the jobs, even though they exist.
https://sippy.dptools.openshift.org/sippy-ng/tests/4.19/details?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22contains%22%2C%22value%22%3A%22FeatureGate%3ACPMSMachineNamePrefix%5D%22%7D%5D%7D

There is an issue with the verify feature promotion at the moment, I'm investigating

/test verify-feature-promotion

Looking at the current feature promotion data, we don't have enough runs to be able to pass this right now. Could you please trigger 10 runs using gangway on each of AWS, Azure, GCP and vSphere.

This feature doesn't work on metal platforms so we will have to except the metal platform requirements here

Looking at the current feature promotion data, we don't have enough runs to be able to pass this right now. Could you please trigger 10 runs using gangway on each of AWS, Azure, GCP and vSphere.

I had triggered 3-5 jobs in all these platforms. Might need to trigger more.

/retest

/test verify-feature-promotion

@chiragkyal: This pull request references OAPE-148 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

/test verify-feature-promotion

/hold cancel

@JoelSpeed I think we have sufficient runs now, verify-feature-promotion is failing due to the metal platform only.

/lgtm

/override ci/prow/verify-feature-promotion

This feature does not support metal platforms, all others have passed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chiragkyal, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial-techpreview

/override ci/prow/e2e-aws-serial-techpreview

Per #2254 (comment)

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial-techpreview

/retest-required

Remaining retests: 0 against base HEAD 9aa03e6 and 0 for PR HEAD cf5f806 in total

/retest-required

Remaining retests: 0 against base HEAD 9aa03e6 and 2 for PR HEAD cf5f806 in total

Oh my tide! How many times will you retest :(
/retest-required

@chiragkyal The change is for 4.20 right? It'll be merged after branching huh? Just checking in case our tests need any update accordingly.

/override ci/prow/verify-feature-promotion

Feature not applicable to metal, everything else passing

/test e2e-aws-serial-techpreview

This should be fixed now

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

@shellyyang1989 The changes will land in 4.19, which means we will GA the feature in 4.19

/retest-required

@chiragkyal Thanks for letting me know. May I know why we are changing the plan?

@chiragkyal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

/test e2e-aws-serial-techpreview

/hold

Speaking with @shellyyang1989 we are ok to move forward with this

/hold cancel

Speaking with @shellyyang1989 we are ok to move forward with this
/hold cancel

Hope @huali9 was looped into the discussion.

/retest-required

Remaining retests: 0 against base HEAD eb41266 and 2 for PR HEAD cf5f806 in total

/override ci/prow/images ci/prow/minor-e2e-upgrade-minor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/images, ci/prow/minor-e2e-upgrade-minor

/override ci/prow/integration

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/integration

/override ci/prow/verify-feature-promotion

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/verify-feature-promotion

Merging manually to avoid endless retests on changes.

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202504241659.p0.g1ee228b.assembly.stream.el9.
All builds following this will include this PR.